Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(rgbpp-btc): OP_RETURN output support #18

Merged
merged 6 commits into from
Mar 10, 2024
Merged

feat(rgbpp-btc): OP_RETURN output support #18

merged 6 commits into from
Mar 10, 2024

Conversation

ShookLyngs
Copy link
Collaborator

Changes

  1. Add support for creating OP_RETURN output with up to 80 bytes of data
  2. Update related tests and docs (the README file of @rgbpp-sdk/btc)
  3. Fix response error message reading from BtcAssetsApi

Reviewers

@Flouse @Dawn-githup @duanyytop

@ShookLyngs ShookLyngs requested a review from Flouse March 8, 2024 13:06
@ShookLyngs ShookLyngs self-assigned this Mar 8, 2024
@Flouse Flouse changed the title feat: OP_RETURN output support feat(rgbpp-btc): OP_RETURN output support Mar 8, 2024
Flouse
Flouse approved these changes Mar 8, 2024
View reviewed changes
Copy link
Contributor

@Flouse Flouse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The tests are clear.

@Flouse Flouse merged commit 09de175 into main Mar 10, 2024
1 check passed
@duanyytop duanyytop deleted the feat/op-return-output branch March 13, 2024 01:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Dawn-githup Dawn-githup Dawn-githup approved these changes

@duanyytop duanyytop duanyytop approved these changes

@Flouse Flouse Flouse approved these changes

Assignees

@ShookLyngs ShookLyngs

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ShookLyngs @Flouse @duanyytop @Dawn-githup